Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular service params #113

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Circular service params #113

merged 3 commits into from
Nov 11, 2024

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Nov 11, 2024

📬 Changes

  • Made the entire TServiceParams available as params (tired of playing stupid games downstream)
  • Created internal.removeFn (moving from is.removeFn defined in hass)
  • Change .extension to .service (org standards update)

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (172feb9) to head (dcda8a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1149      1155    +6     
  Branches       171       171           
=========================================
+ Hits          1149      1155    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoe-codez zoe-codez merged commit e7391d3 into main Nov 11, 2024
5 of 6 checks passed
@zoe-codez zoe-codez deleted the circular_params branch November 11, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant