-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internals upgrades (primary pr) #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoe-codez
changed the title
Drop internal metrics
Move non-essential utils to standalone project
Sep 11, 2024
zoe-codez
changed the title
Move non-essential utils to standalone project
Internals overhaul
Sep 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
===========================================
+ Coverage 74.94% 86.32% +11.37%
===========================================
Files 28 21 -7
Lines 1361 1082 -279
Branches 189 164 -25
===========================================
- Hits 1020 934 -86
+ Misses 329 138 -191
+ Partials 12 10 -2 ☔ View full report in Codecov by Sentry. |
10 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📬 Changes
This PR drops support for metrics and cache internals that were simply unused + not implemented in a way that is not friendly towards future needs.
The only expected breaking change should be removing the
cache
, which will be importable via standalone library. Unless the ESM conversion does something super weird 🤞🏻(Re) moved features
prom-client
metricsImprovements
Fixes
LOG_LEVEL
🎉 More minimal dependencies
> du -sh node_modules 4.2M node_modules
> ls -1 node_modules argparse chalk dayjs dotenv ini js-yaml minimist node-cron uuid
Parallel PRs
🗒️ Checklist
code of conduct