Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internals upgrades (primary pr) #65

Merged
merged 32 commits into from
Sep 25, 2024
Merged

Internals upgrades (primary pr) #65

merged 32 commits into from
Sep 25, 2024

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Sep 10, 2024

📬 Changes

This PR drops support for metrics and cache internals that were simply unused + not implemented in a way that is not friendly towards future needs.

The only expected breaking change should be removing the cache, which will be importable via standalone library. Unless the ESM conversion does something super weird 🤞🏻

(Re) moved features

Improvements

Feature enhancements

Fixes

Stuff that's broken as a result of these changes

  • cleanup types
  • cleanup sleeps on teardown (prevent open handles in tests)
  • create cache project
  • fetch patch for hass
  • fetch patch for everything else
  • refactor tests to use new test runner
  • fatal allowed as LOG_LEVEL

🎉 More minimal dependencies

Minimum dependencies down to 4.2M from 15M previously

> du -sh node_modules
4.2M    node_modules

Tools required by core via peerDependencies

> ls -1 node_modules
argparse
chalk
dayjs
dotenv
ini
js-yaml
minimist
node-cron
uuid

Parallel PRs

everything gets esm compat, eslint, latest deps

if there are existing unit tests, those are refactored into TestRunner

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

@zoe-codez zoe-codez changed the title Drop internal metrics Move non-essential utils to standalone project Sep 11, 2024
@zoe-codez zoe-codez changed the title Move non-essential utils to standalone project Internals overhaul Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 83.92157% with 82 lines in your changes missing coverage. Please review.

Project coverage is 86.32%. Comparing base (4a34fad) to head (0f59adc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/services/scheduler.extension.ts 57.37% 26 Missing ⚠️
src/services/logger.extension.ts 78.99% 22 Missing and 3 partials ⚠️
src/services/als.extension.ts 30.00% 7 Missing ⚠️
src/services/wiring.extension.ts 92.10% 6 Missing ⚠️
src/helpers/config-file-loader.helper.ts 42.85% 4 Missing ⚠️
src/services/configuration.extension.ts 93.33% 3 Missing and 1 partial ⚠️
src/helpers/wiring.helper.ts 88.88% 2 Missing and 1 partial ⚠️
src/helpers/config.helper.ts 83.33% 0 Missing and 2 partials ⚠️
src/helpers/utilities.helper.ts 85.71% 2 Missing ⚠️
src/helpers/events.helper.ts 66.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #65       +/-   ##
===========================================
+ Coverage   74.94%   86.32%   +11.37%     
===========================================
  Files          28       21        -7     
  Lines        1361     1082      -279     
  Branches      189      164       -25     
===========================================
- Hits         1020      934       -86     
+ Misses        329      138      -191     
+ Partials       12       10        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoe-codez zoe-codez changed the title Internals overhaul Internals upgrades (primary pr) Sep 14, 2024
@zoe-codez zoe-codez marked this pull request as ready for review September 24, 2024 19:43
@zoe-codez zoe-codez merged commit b282db4 into main Sep 25, 2024
3 checks passed
@zoe-codez zoe-codez deleted the remove_metrics branch September 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant