Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add-7.10.0 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature/add-7.10.0 #4

wants to merge 1 commit into from

Conversation

OlivierAlbertini
Copy link

Add compatibility to 7.10.0

@StephenOTT
Copy link
Member

@OlivierAlbertini Thanks for the contribution. Was there anything changed in the configuration other than the pom's camunda version?

@OlivierAlbertini
Copy link
Author

OlivierAlbertini commented Feb 7, 2019 via email

@StephenOTT
Copy link
Member

@OlivierAlbertini okay so reviewed this, and 2 things i think need to be fixed for merging:

  1. You have a .DS_STORE file from OSX in your commit. This needs to be removed.

  2. And you have committed your Maven wrapper files, why this on purpose? Likely should be removed.

@OlivierAlbertini
Copy link
Author

Hi @StephenOTT

Sorry for the .DS_Store!

1. You have a .DS_STORE file from OSX in your commit. This needs to be removed.

  1. And you have committed your Maven wrapper files, why this on purpose? Likely should be removed.

For the point 2, I'm not a Java guy 😅, so I follow the 7.9.0 folder structures.
Let me know, what I should remove and I will do it.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants