This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Add versioning and dependencies to Rift loader #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new elements to a Rift mod json: a version String and a dependencies Map<String, String>. The first String in the dependency map is the mod's id, and the second is the minimum version needed.
Version strings are parsed as loose SemVer, and will fail to load (without crashing the game) if there is a missing version (though we might want to give them a dummy version instead for backwards compat). Incorrect dependencies will throw a new MissingDependencyException.
To keep OptiFine being loadable, it has been given its own version string of "1.13".
This is tested and works perfectly. In the future, it would be good to make this crash without closing the Minecraft window a la Forge's dependency catcher, but that's not something I'm able to write at the moment.