Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TUF Favicon #33

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Add TUF Favicon #33

merged 6 commits into from
Aug 28, 2024

Conversation

Dindihub
Copy link
Owner

@Dindihub Dindihub commented Aug 28, 2024 •
edited
Loading

Covers issue #32

Not sure why the Favicon looks blurry. I generated from this image https://github.com/cncf/artwork/blob/main/projects/tuf/icon/color/tuf-icon-color.svg

@Dindihub
Add TUF favicon
97ab570 
Signed-off-by: sandra <[email protected]>
@Dindihub
fix format
aa45ee4 
Signed-off-by: sandra <[email protected]>
@Dindihub
edit favicons
626eb20 
Signed-off-by: sandra <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Aug 28, 2024 •
edited
Loading

✅ Deploy Preview for tufio ready!

Name Link
🔨 Latest commit b8d8b57
🔍 Latest deploy log https://app.netlify.com/sites/tufio/deploys/66cf19adddf47b0008fc0b27
😎 Deploy Preview https://deploy-preview-33--tufio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Dindihub Dindihub requested review from lukpueh and chalin August 28, 2024 09:55
@Dindihub
change icon link
b8d8b57 
Signed-off-by: sandra <[email protected]>
@lukpueh
Copy link
Collaborator

lukpueh commented Aug 28, 2024

Yeah, that looks kinda retro. 👾 Maybe @chalin knows how to fix this? FYI I tried a favicon.io doesn't seem to give a better result either. 🤷

lukpueh
lukpueh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blur doesn't look great, but it's better than no favicon.

chalin
chalin approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably looks blurry because the artwork lines are too thin? Anyhow, this is an improvement over no favicon, so LGTM!

@chalin chalin merged commit 06d084e into main Aug 28, 2024
7 checks passed
@chalin chalin deleted the favicon branch August 28, 2024 18:06
@chalin chalin mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukpueh lukpueh lukpueh approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dindihub @lukpueh @chalin