Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix performance issue with item rarity outlines #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IlmarsXd
Copy link

@IlmarsXd IlmarsXd commented Oct 8, 2024

Uses a single drop-shadow call for the outline.
The performance issue comes from the tooltip rendering causing the full page re-render and therefore reapplies the dropshadow

@FrutyX
Copy link
Collaborator

FrutyX commented Oct 8, 2024

Performance issue? What issue? Modern computers are only getting faster, not slower.

This change is very unnecessary.

@IlmarsXd
Copy link
Author

IlmarsXd commented Oct 8, 2024

Even on good systems, some people (including me) have seen problems with performance due to the outlines.
It might be something specific to the browser, or some settings since comparing similar systems also didnt show the same results.
This still is more efficient and has no downsides

@FrutyX
Copy link
Collaborator

FrutyX commented Oct 8, 2024

You could also turn off item shadows in the settings completely, however, I do not have these performance issues, so I'll just let someone else (Thanos for example) to be the judge of this.

The culprit, like you said, could be somewhere else tho.

@FrutyX FrutyX requested a review from GramThanos October 8, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants