-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover Implementation #180
base: main
Are you sure you want to change the base?
Hover Implementation #180
Conversation
wheregmis
commented
Jan 9, 2025
•
edited
Loading
edited
- Might need to clean up the example
- I have few comments where i might need some inputs
- mouseover/mouseenter/mouseout/mouseleave happens in blitz-dom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a decent change. However, I'm I'm going to try to land #179 first as I think it's better to make these architectural changes before adding more events.
I think we'll want to move to a model where blitz-shell
just passes on the mousemove
event, and detection of mouseover
/mouseenter
/mouseout
/mouseleave
happens in blitz-dom
.
Sure, i will wait for #179 to land. And can try to rebase to it. Till that time i will try to poke the codes during my spare time to know abit more about the codebase. Appreciate the direction and review |
Hi @nicoburns , I did an attempt to make mouseover/mouseenter/mouseout/mouseleave happening in blitz-dom but i am not able to make it happen. We might need to handle the events on Document of blitzshell for the event, which i dont have access to on the blitz-dom. Not sure if i am able to explain it properly. Any guidance will be appreciated. |
Is this somehow related to missing an "active" state on buttons? I started a discussion here: DioxusLabs/dioxus#3622 |
Its not, blitz is currently being developed and is not the default renderer for dioxus. |
This reverts commit a02ca44.