Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover Implementation #180

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Hover Implementation #180

wants to merge 11 commits into from

Conversation

wheregmis
Copy link

@wheregmis wheregmis commented Jan 9, 2025

  • Might need to clean up the example
  • I have few comments where i might need some inputs
  • mouseover/mouseenter/mouseout/mouseleave happens in blitz-dom

@wheregmis wheregmis marked this pull request as draft January 9, 2025 16:25
Copy link
Collaborator

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a decent change. However, I'm I'm going to try to land #179 first as I think it's better to make these architectural changes before adding more events.

I think we'll want to move to a model where blitz-shell just passes on the mousemove event, and detection of mouseover/mouseenter/mouseout/mouseleave happens in blitz-dom.

packages/blitz-dom/src/events/mod.rs Outdated Show resolved Hide resolved
packages/blitz-shell/src/window.rs Outdated Show resolved Hide resolved
@wheregmis
Copy link
Author

Sure, i will wait for #179 to land. And can try to rebase to it. Till that time i will try to poke the codes during my spare time to know abit more about the codebase. Appreciate the direction and review

@wheregmis wheregmis marked this pull request as ready for review January 20, 2025 06:03
@wheregmis wheregmis marked this pull request as draft January 20, 2025 06:33
@wheregmis
Copy link
Author

Hi @nicoburns , I did an attempt to make mouseover/mouseenter/mouseout/mouseleave happening in blitz-dom but i am not able to make it happen. We might need to handle the events on Document of blitzshell for the event, which i dont have access to on the blitz-dom. Not sure if i am able to explain it properly. Any guidance will be appreciated.

@chardskarth
Copy link

chardskarth commented Jan 23, 2025

Is this somehow related to missing an "active" state on buttons?

I started a discussion here: DioxusLabs/dioxus#3622

@wheregmis
Copy link
Author

Is this somehow related to missing an "active" state on buttons?

I started a discussion here: DioxusLabs/dioxus#3622

Its not, blitz is currently being developed and is not the default renderer for dioxus.

@wheregmis wheregmis requested a review from nicoburns January 30, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants