Initial Android support #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
reviewed
Jun 25, 2024
packages/dioxus-blitz/src/lib.rs
Outdated
| let proxy = event_loop.create_proxy(); | ||
|
|
||
| // Multiwindow ftw | ||
| let mut windows: HashMap<WindowId, window::View<'_, Doc>> = HashMap::new(); | ||
| let mut pending_windows = Vec::new(); | ||
|
|
||
| pending_windows.push(window); | ||
| let menu_channel = MenuEvent::receiver(); | ||
|
|
||
| #[cfg(feature = "muda")] |
There was a problem hiding this comment.
I reckon this feature should probably be called "menu" "menubar".
There was a problem hiding this comment.
Totally agree 👍 I went with the name menu in 823f309 but definitely open to menubar as well
I also made the feature flag default, but not usable from Android/IOS, which I think could be easier for end users
… on android or ios)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the initial working support for Android. Interactivity is blocked on touch and gesture support, but HTML can be displayed and seems to work across app launches.
This also adds
docsrsconfiguration to provide information about android-only functions