Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reexport the Warning trait in dioxus-signals #3321

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Dec 10, 2024

feat: Reexport the Warning trait in dioxus-signals to allow the use of ::allow() without pulling the warnings crate

fixes: #3513

… of `::allow()` without pulling the warnings crate
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Dec 11, 2024

Maybe we should be re-exporting warnings from the dioxus namespace?

dioxus::warnings::allow()

@marc2332
Copy link
Contributor Author

Maybe we should be re-exporting warnings from the dioxus namespace?

dioxus::warnings::allow()

In dioxus-lib as well if that was the case

@jkelleyrtp jkelleyrtp linked an issue Jan 7, 2025 that may be closed by this pull request
@jkelleyrtp
Copy link
Member

Changed this to re-export warnings as dioxus::warnings under both dioxus and dioxus-lib

@jkelleyrtp jkelleyrtp merged commit d75cb59 into DioxusLabs:main Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose dioxus_warnings as dioxus::warnings Expose dioxus_cli_config as dioxus::config
2 participants