Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the file engine feature in the html crate a no-op #3392

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ealmloff
Copy link
Member

This PR removes all usage of the the file engine feature flag in the html crate. This feature flag is useful to reduce the binary size of web builds which used to live in the html crate. Now that the bindings are moved to the web crate, we can remove the feature flag from dioxus-html.

This PR does not actually remove the feature flag because that would be a breaking change. This PR does enable a method on a trait when the file_engine trait is disabled, but that method has a default implementation so adding the method should be non-breaking.

I manually tested building the dioxus-web crate with the default features disabled and only the mounted, file_engine, or hydrate features enabled and all three builds succed.

Fixes #3383

@ealmloff ealmloff added bug Something isn't working html Related to the html crate labels Dec 18, 2024
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we can remove all the weird flags... 🫠

@jkelleyrtp jkelleyrtp merged commit aab1258 into DioxusLabs:main Dec 20, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html Related to the html crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File engine does not exist on the server
2 participants