Make the file engine feature in the html crate a no-op #3392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all usage of the the file engine feature flag in the html crate. This feature flag is useful to reduce the binary size of web builds which used to live in the html crate. Now that the bindings are moved to the web crate, we can remove the feature flag from dioxus-html.
This PR does not actually remove the feature flag because that would be a breaking change. This PR does enable a method on a trait when the
file_engine
trait is disabled, but that method has a default implementation so adding the method should be non-breaking.I manually tested building the dioxus-web crate with the default features disabled and only the
mounted
,file_engine
, orhydrate
features enabled and all three builds succed.Fixes #3383