Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage hook #17

Merged
merged 117 commits into from
Apr 1, 2024
Merged

Add storage hook #17

merged 117 commits into from
Apr 1, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Sep 23, 2023

Adds a storage hook to dioxus std that works on both desktop and web

Stacked on #23

@ealmloff ealmloff marked this pull request as draft March 27, 2024 23:52
@ealmloff ealmloff marked this pull request as ready for review March 28, 2024 00:32
@marc2332
Copy link
Collaborator

some conflicts @ealmloff

@marc2332 marc2332 removed the waiting on next dioxus release Waiting on the next Dioxus release before action. label Mar 28, 2024
@marc2332 marc2332 self-requested a review March 28, 2024 22:32
Copy link
Member

@DogeDark DogeDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Great work!

examples/storage/Cargo.toml Outdated Show resolved Hide resolved
std/Cargo.toml Outdated Show resolved Hide resolved
std/src/geolocation/mod.rs Outdated Show resolved Hide resolved
std/src/storage/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@DogeDark DogeDark merged commit 74d9eaa into DioxusLabs:master Apr 1, 2024
4 checks passed
@DogeDark
Copy link
Member

DogeDark commented Apr 1, 2024

Thank you!!

@ealmloff ealmloff deleted the storage branch April 1, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants