-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove layout_flexbox
function from prelude
#415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes. @nicoburns, what are your plans for the next breaking release? I think we should probably hold off on this PR until we have a better reason for a breaking release.
My plan is roughly to include the following:
I'm pretty happy to accept breaking changes into Finally, I would note that I'm not sure that the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rustfmt and markdown lints need to be fixed.
fa39693
to
c5d69a6
Compare
layout_flexbox
function from prelude
Objective
The prelude contained a single method that has been kept around for backwards compatibility. It is simply a wrapper around
FlexboxAlgorithm::perform_layout()
. The idiomatic way to use taffy now and going forward is to use theperform_layout()
on the trait so I don't think we need to keep this around for much longer.The migration path is also very simple, but it is a breaking change.
Feedback wanted
Are there any reasons why we would not want this? Or want to delay this? I know #326 might change how end users interact with taffy, and so we might want to bundle these changes together?