Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement voice gateway v8 #146

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Implement voice gateway v8 #146

merged 2 commits into from
Jan 30, 2025

Conversation

longnguyen2004
Copy link
Collaborator

@longnguyen2004 longnguyen2004 commented Jan 30, 2025

Notable changes in v8:

  • Some messages now contain a seq property, which is a sequence number. Clients must send the last received sequence number on heartbeat and resume messages.

Binary messages are used for DAVE, which we can't deal with yet.
Copy link

pkg-pr-new bot commented Jan 30, 2025

Open in Stackblitz

npm i https://pkg.pr.new/Discord-RE/Discord-video-stream/@dank074/discord-video-stream@146

commit: 2e069f7

@longnguyen2004 longnguyen2004 marked this pull request as ready for review January 30, 2025 03:17
Copy link
Member

@dank074 dank074 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@longnguyen2004
Copy link
Collaborator Author

Testing seems fine, merging this now

@longnguyen2004 longnguyen2004 merged commit 7dde773 into master Jan 30, 2025
5 checks passed
@longnguyen2004 longnguyen2004 deleted the voice-gateway-v8 branch January 30, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants