Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data management rewrite #149

Merged
merged 22 commits into from
Feb 8, 2024
Merged

Data management rewrite #149

merged 22 commits into from
Feb 8, 2024

Conversation

vyPal
Copy link
Contributor

@vyPal vyPal commented Nov 13, 2023

Description

This PR completely rewrites the way in which EduPage2 handles data from the API server. It aims to remove the mess of session managers, and shared preference calls scattered around the files.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test coverage

Test Configuration:

  • OS and version: Fedora Workstation 38
  • Hardware (or VM): Android Studio Emulator
  • API (version/selfhosted): v1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vyPal vyPal merged commit 10f29b1 into master Feb 8, 2024
4 of 5 checks passed
@vyPal vyPal deleted the data-management-rewrite branch February 9, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants