Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message sending #160

Merged
merged 24 commits into from
May 7, 2024
Merged

Message sending #160

merged 24 commits into from
May 7, 2024

Conversation

vyPal
Copy link
Contributor

@vyPal vyPal commented Mar 19, 2024

Description

Adds the ability to send messages from the EduPage2 app

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been tested under the standard coverage tests

  • Test coverage

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 95 lines in your changes are missing coverage. Please review.

Project coverage is 69.31%. Comparing base (6983b3a) to head (4af2617).
Report is 15 commits behind head on master.

Files Patch % Lines
lib/create_message.dart 55.62% 75 Missing ⚠️
lib/message.dart 25.92% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   70.68%   69.31%   -1.37%     
==========================================
  Files          12       14       +2     
  Lines        1634     1910     +276     
==========================================
+ Hits         1155     1324     +169     
- Misses        479      586     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vyPal vyPal merged commit f7324f2 into master May 7, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant