CADENZA-37480 Feat: Import geojson layers in create and edit geometry #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivigilm
commented
Oct 16, 2024
jkissel
requested changes
Oct 17, 2024
src/docs.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| Create a GeoJSON polygon geometry with a workbook map view and some additional layers in the background. |
There was a problem hiding this comment.
Proposal: Add a sub-heading here (####), so that this shows up in the TOC.
There was a problem hiding this comment.
I envisioned this as a sub-example of "Create a New Geometry", that's why I suggested ####.
And the heading should be in title case, see https://conf.disy.net/x/rIREH
jkissel
approved these changes
Oct 17, 2024
src/docs.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| Create a GeoJSON polygon geometry with a workbook map view and some additional layers in the background. |
There was a problem hiding this comment.
I envisioned this as a sub-example of "Create a New Geometry", that's why I suggested ####.
And the heading should be in title case, see https://conf.disy.net/x/rIREH
src/docs.md
Outdated
|
|
||
| ```javascript | ||
| cadenzaClient.createGeometry('<embeddingTargetId>', 'Polygon', { | ||
| additionalLayers: [{"name":"layer_name_1","type":"geojson","content": {replace_with_geojson_FeatureCollection}},{"name":"layer_name_2","type":"geojson","content":{replace_with_geojson_FeatureCollection},{"name":"layer_name_3","type":"geojson","content":{replace_with_geojson_FeatureCollection}}] |
There was a problem hiding this comment.
The other placeholders in here use <>. Proposal:
#### Additional Background Layers
Create a GeoJSON polygon geometry with a workbook map view and some additional background layers.
```javascript
cadenzaClient.createGeometry('<embeddingTargetId>', 'Polygon', {
additionalLayers: [
{ type: 'geojson', name: 'Example', content: { <FeatureCollection> } },
...
]
});(Fixes also the above "issues".)
aggregat4
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.