Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slb/ad/cadenza 38410 #74

Merged
merged 9 commits into from
Nov 26, 2024
Merged

Slb/ad/cadenza 38410 #74

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
73763b0
CADENZA-38410 fix: removed duplicate: geometry div
Nov 26, 2024
2b1078b
CADENZA-38410 fix: introduce 'sticky' sidebar horizontal scrollbar
Nov 26, 2024
3523146
CADENZA-38410 doc: adjusted CHANGELOG.md
Nov 26, 2024
0d96fd8
CADENZA-38410 fix: fix label for id
Nov 26, 2024
81c0d1d
CADENZA-38410 fix: introduce template for geometry section and added…
Nov 26, 2024
d7aa388
Revert " CADENZA-38410 fix: introduce 'sticky' sidebar horizontal scr…
Nov 26, 2024
13a7542
CADENZA-38410 fix: use more compact examples
Nov 26, 2024
039663f
CADENZA-38410 doc: adjusted CHANGELOG.md
Nov 26, 2024
e069a0f
CADENZA-38410 doc: adjusted CHANGELOG.md
Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
This project uses a version scheme based on the Cadenza main version in the format x.x.y, where x.x is the Cadenza main version and y a functional change or bugfix.

## Unreleased
### Fixed
- Removed duplicate geometry section in `sandbox.html#editGeometry`
- Horizontal scrollbar in `sandbox.html` left sidebar now appears sticky.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Horizontal scrollbar is rather painful to use. Why do we want it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have it due to long explaination texts, and this is a improvement to the current state imo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the sidebar is fixed width. We should be able to craft the contents in a way that does not require a horizontal scrollbar. For example texts should wrap lines. We can have a look if necessary.


## 10.2.6 - 2024-11-25
### Fixed
Expand Down
23 changes: 1 addition & 22 deletions sandbox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
aside {
background: var(--bg);
grid-area: aside;
overflow: hidden auto;
overflow: auto;
}
form {
padding-inline: var(--padding);
Expand All @@ -39,7 +39,6 @@
display: flex;
flex-direction: column;
gap: var(--gap);
overflow: scroll;
}
fieldset > div {
display: flex;
Expand Down Expand Up @@ -651,26 +650,6 @@
</pre>
</small>
</div>
<div>
<label for="geometry">Geometry (GeoJSON)</label>
<textarea name="geometry" id="geometry" rows="5"></textarea>
<small>
<strong>Example:</strong>
<pre>
{
"coordinates":[
[
[9.598504509838506,52.70992820638244],
[8.899110702389294,51.72257425885121],
[10.906499617840836,51.725944168909365],
[9.598504509838506,52.70992820638244]
]
],
"type":"Polygon"
}
</pre>
</small>
</div>
</template>

<template id="common-extentStrategy">
Expand Down