-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displaying Gregorian Chants #3699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Update Prayers.txt
partially addressing DivinumOfficium#838
Enabling DivinumOfficium#1375 (GABC files are not retrieved from GregoBase though)
Magnificat, Benedictus, Nunc Dimittis, Ezechias, Moses Ex15, Habacuc
APMarcello3
added a commit
that referenced
this pull request
Mar 29, 2024
gallizoltan
pushed a commit
to gallizoltan/divinum-officium
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far from complete @APMarcello3 , however, hopefully in time for two more Tenebræ, I feel this "beta" version is ready to be made available for general use.
This does not yet fully address the long open issue #1375 . I have not been succesfull in retrieving the score directly from GregoBase but needed to download them @ahinkley and store them. For antiphones which are un-doubled, these have to be filled directly into the database files as before.
I'll follow up with a technical description. I am sure there are lot's of issues with the adding of a... once we enter Eastertide.
It's all running on my Apache localhost with JavaScript enabled. I'll keep my fingers crossed it works with the Docker image on the website as well. @benyanke
Blessed Triduum!