Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve object filtering #114

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

melegiul
Copy link
Contributor

@melegiul melegiul commented Mar 7, 2022

Thank you for sharing this awesome app, it does a great job 🎉
This PR allows to pass a function in a linklist class to apply advanced filters like Subqueries, Q and F objects, etc
and solves #77 partially and can be combined with the current object filter options
Thanks in advance for your feedback

@claudep
Copy link
Contributor

claudep commented Mar 7, 2022

Thanks Giuliano for this proposal, I think it makes sense. Would it be possible to add a test for the new functionality? I'd also move the documentation from the code to the README (under Linklist classes).

@melegiul
Copy link
Contributor Author

melegiul commented Mar 8, 2022

Thank you very much for your review.
I have added a test case for the filter_callable attribute and moved its documentation into the README.

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready :-)

README.rst Outdated Show resolved Hide resolved
linkcheck/tests/sampleapp/linklists.py Show resolved Hide resolved
@melegiul melegiul force-pushed the improvement/object-filter branch from d72200f to fa43049 Compare March 11, 2022 16:16
@claudep
Copy link
Contributor

claudep commented Mar 12, 2022

Thanks a lot for your contribution!

@claudep claudep merged commit 8cb97b1 into DjangoAdminHackers:master Mar 12, 2022
@melegiul melegiul deleted the improvement/object-filter branch March 23, 2022 09:32
@melegiul
Copy link
Contributor Author

melegiul commented Mar 23, 2022

@claudep Thank you once again, it was a real pleasure to work with you 🙂
Is there anything I can do to help releasing this one? We would be very happy to use this for our next migration

@claudep
Copy link
Contributor

claudep commented Mar 23, 2022

Sure, I'll prepare a new release soon.

@claudep
Copy link
Contributor

claudep commented Mar 23, 2022

Released 1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants