Fix animation behavior with negative horizontal offset to support narrower drawer. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for a negative offset to be used for narrower drawers in landscape. Co-Authored-By: JonnyWong16 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
flutter_inner_drawersupports using a negative horizontal offset. However, doing so breaks the animation when revealing and hiding the drawer, forcing you to use a minimum horizontal offset of0.This change fixes that, allowing drawers that are narrower than half the screen width to be configured. Supporting this is particularly useful for devices in landscape mode like tablets.
The changes to the drift (difference in movement compared to gesture) is almost negligible and is comparable to the drift that already exists.
The value of
2.05was used when manually tuning as it offered the most similar experience for both positive and negative offsets.