Skip to content

Commit

Permalink
BREAKING: Button refactor; remove ButtonLink; introduce IconButton
Browse files Browse the repository at this point in the history
  • Loading branch information
gnapse committed Jul 4, 2024
1 parent 24dba33 commit 12cc4f4
Show file tree
Hide file tree
Showing 29 changed files with 1,504 additions and 1,969 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

# v25.0.0-beta

- [BREAKING] Removed the `ButtonLink` component.
- [BREAKING] `Button` no longer accepts props that render it as an icon-only button.
- [Feat] Introduce a new `IconButton` component.
- [Feat] The `Button` and `IconButton` component can be rendered as a link using the `render={<Link to="" />} prop.

# v24.2.0-beta

- [Fix] Include changes from [v23.3.0](#v2330) in the beta release
Expand All @@ -17,7 +24,7 @@ Reactist follows [semantic versioning](https://semver.org/) and doesn't introduc
# v24.1.3-beta

- [Fix] Remove unsupported `onPointerEnterCapture` and `onPointerLeaveCapture` props from `heading`-, `input`-, and `textarea`-based components.
- Normally, this would be considered a breaking change, but the v24 version is still pre-release and already contains breaking changes.
- Normally, this would be considered a breaking change, but the v24 version is still pre-release and already contains breaking changes.

# v24.1.2-beta

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"email": "[email protected]",
"url": "http://doist.com"
},
"version": "24.2.0-beta",
"version": "25.0.0-beta",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": {
Expand Down
6 changes: 3 additions & 3 deletions src/banner/banner.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Box } from '../box'
import { Text } from '../text'
import { Stack } from '../stack'
import { Banner } from './banner'
import { ButtonLink } from '../button-link'
import { Button } from '../button'

<Meta
title="Design system/Banner"
Expand Down Expand Up @@ -117,9 +117,9 @@ export function EyeIcon(theme) {

export function getButton(buttonText) {
return (
<ButtonLink variant="primary" tone="destructive">
<Button variant="primary" tone="destructive">
{buttonText}
</ButtonLink>
</Button>
)
}

Expand Down
54 changes: 0 additions & 54 deletions src/base-button/base-button.stories.mdx

This file was deleted.

180 changes: 0 additions & 180 deletions src/base-button/base-button.tsx

This file was deleted.

1 change: 0 additions & 1 deletion src/base-button/index.ts

This file was deleted.

Loading

0 comments on commit 12cc4f4

Please sign in to comment.