chore: increase show tooltip delay to 1 second #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloomca
commented
Dec 11, 2023
| () => { | ||
| expect(button).toHaveAccessibleDescription('tooltip content here') | ||
| }, | ||
| { timeout: SHOW_DELAY + 10 }, |
There was a problem hiding this comment.
Default timeout is 1 second, so we basically just need one tick. This is a scalable solution, although each test would take 1 second (instead of 500ms before), so we can advance timers manually. Since we don't have that many tests, I think it is okay to keep it like that.
gnapse
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Increase tooltip show delay to 1 second
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refVersioning
This is a patch change.