Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More ariakit upgrade fixes #817

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Mar 7, 2024

Short description

The changes here fix two issues we detected while attempting to upgrade to this version of Reactist and the new Ariakit in todoist-web:

  1. 🟠 Opening the settings via keyboard while a menu is expanded, keeps the menu on top of the settings modal (https://share.cleanshot.com/SjvnsDLz)

    Screen recording

    CleanShot.202024-02-16.20at.2014.00.26.mp4

  2. 🟠 Clicking with the mouse outside a tooltip to dismiss it and then hovering buttons will keep the tooltips rendered indefinitely (https://share.cleanshot.com/Y4mt2xWT)

    Screen recording

    CleanShot.202024-02-16.20at.2014.14.15.mp4

PR Checklist

  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Sorry, something went wrong.

@gnapse gnapse self-assigned this Mar 7, 2024
@gnapse gnapse force-pushed the ernesto/more-ariakit-upgrade-fixes branch from f9bb117 to 354f53f Compare March 7, 2024 13:18
@gnapse gnapse merged commit c95df9a into next Mar 7, 2024
5 checks passed
@gnapse gnapse deleted the ernesto/more-ariakit-upgrade-fixes branch March 7, 2024 13:29
nats12 pushed a commit that referenced this pull request May 31, 2024
* Remove hack to hide tooltips when clicking to dismiss a button popover
* Simplify Menu's onItemSelect handling internally
* Hide menus when they lose focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant