Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust modal alignment to middle at breakpoint #821

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,10 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

# v23.2.1

- [Fix] Adjust modal alignment to the middle of the viewport at `800px` breakpoint for improved UX.

# v23.2.0

- [Feat] Add `medium` as a `weight` option for `Header`.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
"email": "henning@doist.com",
"url": "http://doist.com"
},
"version": "23.2.0",
"version": "23.2.1",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": {
16 changes: 13 additions & 3 deletions src/modal/modal.module.css
Original file line number Diff line number Diff line change
@@ -43,9 +43,6 @@
.overlay.fitContent > [data-focus-lock-disabled] {
padding-top: var(--reactist-modal-padding-top);
}
.overlay.fitContent > [data-focus-lock-disabled] .container {
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
}

.container {
box-shadow: 0px 2px 8px 0px rgba(0, 0, 0, 0.16);
@@ -118,6 +115,19 @@
}
}

@media (min-height: 800px) {
.overlay.fitContent > [data-focus-lock-disabled] .container {
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
}
}

@media (max-height: 800px) {
.overlay.fitContent > [data-focus-lock-disabled] {
padding-top: var(--reactist-spacing-xxlarge);
justify-content: center;
}
}

/* header */

.buttonContainer {