-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve DX when developing against another repo #831
Conversation
There is an issue with some tsdx dependencies (the rollup typescript plugin) that causes ts declarations to not be rebuilt when running tsdx. See rollup/plugins#418
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Can't wait to see it in action.
Unfortunately, I saw this today too late to try it. Will try this Wednesday. I did leave some comments here of a couple of things that are unclear to me.
Short description
We are implementing a yalc-based workflow for working on Reactist and seeing those changed reflected in a locally running app that has a dependency on Reactist.
This partially addresses #675:
PR Checklist
Added tests for bugs / new featuresExecutednpm run validate
and made sure no errors / warnings were shownDescribed changes inCHANGELOG.md
Bumped version inpackage.json
andpackage-lock.json
(npm --no-git-tag-version version <major|minor|patch>
) refReviewed and approved Chromatic visual regression tests in CIVersioning
This is a DX-only change that does not require a new version release.