Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TooltipContext to set global timeout values #846

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

frankieyan
Copy link
Member

@frankieyan frankieyan commented Oct 26, 2024

Short description

Back in #845, I exposed Ariakit's showTimeout and hideTimeout props to Tooltip to allow for customization, but it wasn't until I went to integrate it did I realize my mistake - we don't want to have to set this on every single tooltip instance 🥲 So we are adding a provider in order to be able to define these values just once in the app.

Ref: https://github.com/Doist/Issues/issues/15139

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Minor

@frankieyan frankieyan self-assigned this Oct 26, 2024
@frankieyan frankieyan requested review from a team and pedroalves0 and removed request for a team October 26, 2024 05:25
@frankieyan frankieyan merged commit ec1f638 into main Oct 29, 2024
5 checks passed
@frankieyan frankieyan deleted the frankie/tooltip-provider branch October 29, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants