Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typo "accesed" changed to "accessed" for TS code #1069

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

nktnet1
Copy link

@nktnet1 nktnet1 commented Jan 8, 2025

This PR fixes the typo "accesed" -> "accessed" in TS files - specifically:

  • accessedProjects
  • accessedServices

I've left the mapping to DB untouched (unsure how Dokploy handles migrations in version upgrades atm).


As an aside, I was discovered this while attempting to implement the "custom sort order" services for projects and services (suggested in #700). It appears that a user's access to projects and services are stored as string arrays instead of in dedicated permission tables:

accesedProjects: text("accesedProjects")
.array()
.notNull()
.default(sql`ARRAY[]::text[]`),
accesedServices: text("accesedServices")
.array()
.notNull()
.default(sql`ARRAY[]::text[]`),

which makes it difficult to implement a custom sort order on a per-user basis.

Would you be open to receiving a PR that normalises the schema + changes the way user permissions are handled?
E.g. replacing arrays with junction tables joining users with projects, and a users with services.
This is quite a big change so asking first before attempting.

@nktnet1 nktnet1 requested a review from Siumauricio as a code owner January 8, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant