Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker-compose #8

Closed
wants to merge 2 commits into from
Closed

Conversation

itschip
Copy link
Contributor

@itschip itschip commented Apr 30, 2024

Adds a simple docker-compose file for development

@itschip itschip requested a review from Siumauricio as a code owner April 30, 2024 14:11
@Siumauricio
Copy link
Contributor

Thank you for your PR @itschip !

could you add the traefik configuration?

Here is the config

https://github.com/Dokploy/dokploy/blob/main/server/setup/traefik-setup.ts#L10

@therumbler
Copy link

great idea! (Docker Compose)

any reason you haven't added dokploy itself to the compose file?

  docploy:
    build: .
...

@itschip
Copy link
Contributor Author

itschip commented Apr 30, 2024

@therumbler this is mainly meant for setting up requirements for development. Perhaps the file name could be changed to more clearly communicate it?

@Siumauricio
Copy link
Contributor

great idea! (Docker Compose)

any reason you haven't added dokploy itself to the compose file?

  docploy:
    build: .
...

There is no a specific reasson tbh 😅, it was working for me but is not the ideal way to work, this is really essential when you install the app in a vps but on dev mode no sense

@itschip
Copy link
Contributor Author

itschip commented Apr 30, 2024

@Siumauricio if there isn't anything else you want from me, this PR is ready to go from my side!

@Siumauricio
Copy link
Contributor

@itschip Thank you for the PR, i make some adjustments since we don't use docker compose, we use docker swarm so if we use the compose some features will not be available to use in the project you can check here. Also updated how to run the project, i started from scratch (deleted all the files) and everything and it was working without any weird errors/issues and in the new pr you can check the new instructions

Let's move to this PR #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants