Add base directory and pnpm support #1
Conversation
|
Note that we'll need to keep our fork alive until your PR is merged as well as this coinbase/salus#445 issue is addressed. |
| AUDIT_COMMAND = 'pnpm audit --json'.freeze | ||
|
|
||
| def should_run? | ||
| @repository.package_lock_json_present? | ||
| true | ||
| end | ||
|
|
||
| def version | ||
| shell_return = run_shell('npm audit --version') | ||
| shell_return = run_shell('pnpm --version') |
There was a problem hiding this comment.
This looks like it breaks npm support. Is that desired? I'd expect this to be additive.
There was a problem hiding this comment.
Yeah, I took a shortcut in the interest of time since we won't need npm support on our private fork. I can make it additive, but will take some time to figure out how to crawl up from the basedir to find the pnpm lockfile (instead of returning true) and all of the necessary places to hook into to provide pnpm as a standalone thing. Happy to do it if you think it's time well spent, but I was hoping the coinbase maintainers would do it in the issue I opened.
There was a problem hiding this comment.
For the specific purposes of our fork I think this is ok. It would be nice if we could submit a PR to Salus rather than just an issue, but I also understand that we have higher priority things to work on. I'm not super optimistic we'll be able to get off of our fork any time soon though 😢
Support for the configuration we need in the new monorepo structure.