Added class to handle Pebble bundles. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class AppInfo < BinData::Record | ||
| endian :big | ||
|
|
||
| string :header, :length => 8, :asserted_value => "PBLAPP\0\0" |
|
The code itself looks fine, I just have some style complaints. Nice work otherwise! |
|
Also, please make mention of this in the readme, in the same place I mention Pebble::Protocol for example. |
|
I have fixed everything but lazy initialization (see line comment above). Shall I also convert tab indentation to two spaces? |
|
I see you've already fixed everything—awesome. I'll pull it in later tonight. |
DouweM
added a commit
that referenced
this pull request
Sep 28, 2013
Added class to handle Pebble bundles.
|
Yay! This was probably my first contribution to a actually useful tool ever! (if you don't count OS X homebrew) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a class to handle the information in Pebble bundles. Might be handy when trying to implement app/firmware upload. This implements the file structure as reported here. The actual implementation is similar to the Python libpebble.
I also added an example file to show case the API.