-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for pending operations #172
base: stable
Are you sure you want to change the base?
Conversation
I'm still undecided if this should be
|
I don't have a preference in this case. If there are any guarantees, possible side-effects e.g. |
@swilly22 what was the background for this PR? What is your use case? The C committee is discussing it. |
RedisGraph may use a matrix |
I'm getting ready to release GraphBLAS 8.2.2 with some minor updates (in SuiteSparse 7.4), and I'm waiting on the 2.1 C API to be released so that I can release GraphBLAS 9.0.0 with the latest GrB get/set methods. Kernel fusion might render this method a challenge. I haven't started kernel fusion yet but it would be a problem if I added this method to GraphBLAS now, only to have to take it out when I get to that project. So for now, let's hold of. It works for now inside FalkorDB and RedisGraph, for GraphBLAS 8.x and 9.x. I hope to keep it in place for GraphBLAS when I add kernel fusion but time will tell. |
Can you please explain how |
Unsure, but I need to somehow flag a matrix as taking part in one or more pending GraphBLAS operations. There's a possibility that keeping GxB_Matrix_pending functional when kernel fusion is added would be complicated, and might need an API change. |
This pull-request adds the
GxB_Matrix_pending
function which checks if a matrixA
has any pending work:In which case the functions sets its input/output argument to true otherwise the argument is set to false.
Please let me know if I should add a test.