Initial gradle build #212
Initial gradle build #212
Conversation
midttuna
force-pushed
the
sdccc-gradle
branch
from
e40279a
to
28c14a9
Compare
| org-junit-jupiter-junit-jupiter-api = "5.10.2" | ||
| org-junit-jupiter-junit-jupiter-engine = "5.10.2" | ||
| org-junit-jupiter-junit-jupiter-params = "5.10.2" |
There was a problem hiding this comment.
One of the intentions of having this file is not having to maintain separate versions where the version number is actually shared. Please consolidate duplicate versions into single entries where possible
| @@ -0,0 +1,7 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip | |||
There was a problem hiding this comment.
Use a more recent version, at the time of writing 8.10.2 is the latest release
| @@ -0,0 +1,12 @@ | |||
| allprojects { | |||
There was a problem hiding this comment.
Using allprojects/subprojects is considered bad practice by the gradle community and developers now and should be avoided. Move this to the java-conventions plugin
| } | ||
|
|
||
| val jaxb: Configuration by configurations.creating | ||
| val jaxbVersion: String = "4.0.0" |
| val jaxb: Configuration by configurations.creating | ||
| val jaxbVersion: String = "4.0.0" | ||
| val schemaDir = "src/main" | ||
| val xjcOutputDir = "$buildDir/generated/source/xjc/main" |
| // force generated javadoc to english | ||
| javaExec.jvmArgs = listOf("-Duser.language=en-US") | ||
|
|
||
| javaExec.args = mutableListOf( |
There was a problem hiding this comment.
This enables way more flags and plugins than we previously did, changing the data model somewhat. Should only happen in a separate PR if needed.
| val connection = url.openConnection() | ||
| connection.connect() |
There was a problem hiding this comment.
This is using the default configuration of indefinite timeouts, which we very likely do not want.
| } | ||
|
|
||
| dependencies { | ||
| implementation("com.github.jk1:gradle-license-report:2.0") |
There was a problem hiding this comment.
2.0 is over three years old, current release is 2.9
| private fun downloadLicense(licenseUrl: String, moduleName: String, fileName: String) { | ||
| val sanitizedUrl = licenseUrl.trim() | ||
| val url = URL(sanitizedUrl) | ||
| val safeModuleName = moduleName.replace("[^a-zA-Z0-9.-]".toRegex(), "_") |
|
|
||
| val projectName = "SDCcc-gradle" | ||
|
|
||
| launch4j { |
There was a problem hiding this comment.
Consider providing something we can reuse in other places instead of hardcoding it here - convention plugin? :)
|
Also remove the maven files ;) |
// Initial migration to gradle
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: