add new device response for indicate next cal time #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldeichmann
reviewed
Nov 22, 2024
ldeichmann
reviewed
Nov 25, 2024
src/t2iapi/device/types.proto
Outdated
| /* | ||
| Represents a container for MDIB version attributes. | ||
| */ | ||
| message MdibVersion { |
There was a problem hiding this comment.
Consider renaming this MdibVersionGroup and moving it to biceps, like the other types there that exactly represent biceps
ldeichmann
reviewed
Nov 25, 2024
| */ | ||
| message MdibVersionGroup { | ||
| google.protobuf.UInt64Value mdib_version = 1; // optional MdibVersion when finishing the rpc | ||
| google.protobuf.StringValue sequence_id = 2; // SequenceId when finishing the rpc |
There was a problem hiding this comment.
SequenceId is not optional and should remain a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework device manipulation IndicateTimeOfNextCalibrationToUser with new response IndicateTimeOfNextCalibrationToUserResponse.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: