-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
u3d/installer: support custom install paths through U3D_EXTRA_PATHS #373
u3d/installer: support custom install paths through U3D_EXTRA_PATHS #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks on the code.
More generally I am just wondering about the ease of use of the feature. We pass arguments to install
but use a variable here. Maybe a more usable way would be for u3d to keep track of those locations somewhere?
Finally after we agree on the feature, we need to update the doc.
Understood. I did think about having some sort of My rationale is that with the introduction of the Unity Hub and its CLI, And from a user perspective, one could only have to specify the env in the .bashrc or something. Maybe we could a comment about this when installing Unity at an usual location. Something like:
|
I'll explain our case which is very simple. Until now we had a 256GB SSD disk for the operating system and the different versions of Unity. As you can imagine, it is very short because we work with many projects in parallel in different versions of Unity and different platforms. This makes the disk fill very fast. Recently we have installed in two Jenkins nodes two 1TB SSD disks and that's when I found the problem of not being able to automate what I had until now in non-standard directories. For our case, which is CI, it is good that they are environment variables because they are very easy to configure. |
557fb40
to
295d30c
Compare
Pull Request Checklist
bundle exec rspec
to make sure that my PR didn't break any testbundle exec rubocop
to make sure that my PR is inline with our code stylePull Request Description
u3d install
supports custom installation paths, but does not list them correctly in the rest of the application.This means that
u3d run
, package installs and such commands will not detect properly the version installed in a custom path.This fixes this behaviour by adding an environment variable
U3D_EXTRA_PATHS
which is a list of additional paths to look for installed Unity versions.Fixes #370
Fixes #371