Collector metadata #1184
Open
Collector metadata #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +84,8 @@ async def start(self): | |||
| f"[{time_frame_index}/{len(self.time_frames)}] Collecting {symbol} history on {time_frame}...") | |||
| await self.get_ohlcv_history(self.exchange_name, symbol, time_frame) | |||
| await self.get_kline_history(self.exchange_name, symbol, time_frame) | |||
| # create description | |||
| await self._create_description() | |||
There was a problem hiding this comment.
can we also move this line in bot_snapshot_with_history_collector.py please ?
| assert collector.temp_file_path is not None | ||
| assert not os.path.isfile(collector.temp_file_path) | ||
| assert os.path.isfile(collector.file_path) | ||
| assert os.path.isfile(collector.metadata_file_path) |
| assert os.path.isfile(collector.file_path) | ||
| async with collector_database(collector) as database: | ||
| ohlcv = await database.select(enums.ExchangeDataTables.OHLCV) | ||
| # use > to take into account new possible candles since collect max time is not specified | ||
| assert len(ohlcv) > 19316 | ||
| h_ohlcv = await database.select(enums.ExchangeDataTables.OHLCV, time_frame="4h") | ||
| assert len(h_ohlcv) == len(symbols) * BINANCE_MAX_CANDLES_COUNT | ||
| symbols_description = json.loads((await database.select(enums.DataTables.DESCRIPTION))[0][3]) | ||
| symbols_description = data.get_metadata_description(collector.metadata_file_path)\ |
|
can we also rebase and target this branch towards the dev branch please ? |
| assert os.path.isfile(collector.file_path) | ||
| async with collector_database(collector) as database: | ||
| ohlcv = await database.select(enums.ExchangeDataTables.OHLCV) | ||
| # use > to take into account new possible candles since collect max time is not specified | ||
| assert len(ohlcv) > 19316 | ||
| h_ohlcv = await database.select(enums.ExchangeDataTables.OHLCV, time_frame="4h") | ||
| assert len(h_ohlcv) == len(symbols) * BINANCE_MAX_CANDLES_COUNT | ||
| symbols_description = json.loads((await database.select(enums.DataTables.DESCRIPTION))[0][3]) | ||
| symbols_description = data.get_metadata_description(collector.metadata_file_path)\ |
There was a problem hiding this comment.
Suggested change
| symbols_description = data.get_metadata_description(collector.metadata_file_path)\ | |
| symbols_description = data.get_metadata_description(collector.file_path)\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR : Drakkar-Software/OctoBot-Backtesting#186