Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid wait forever from t/pod/pod2usage2.t #11

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

atoomic
Copy link
Member

@atoomic atoomic commented Oct 5, 2020

Fixes #10

@atoomic atoomic requested a review from marekro October 5, 2020 22:11
@atoomic
Copy link
Member Author

atoomic commented Oct 5, 2020

This is now showing some additional issues

#   Failed test 'Output test pod2usage with special perldoc case'
#   at t/pod/pod2usage2.t line 372.
#                   '#You need to install the perl-doc package to use this program.
# '
#     doesn't match '(?^s:^\s*$)'
# Got:
# #You need to install the perl-doc package to use this program.
# Looks like you failed 1 test of 42.
t/pod/pod2usage2.t .....

Fixes Dual-Life#10

We need to be sure to use the last version of
several Pod modules in order to avoid issues.

Also note that perldoc is by default not available
on ubuntu containers and points to a fake binary.

This is adding an extra workflow to check the two
scenario.

This is also fixing a warning from the windows workflow.
Copy link
Collaborator

@marekro marekro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment, I think it is OK to SKIP as implemented. I need to look into that in more detail, and simulate what happens without perldoc being available. pod2usage should be able to deal with both situations anyway (perldoc being there or not). 2nd order optimization :)

@marekro marekro merged commit b00daa2 into Dual-Life:master Oct 6, 2020
@atoomic
Copy link
Member Author

atoomic commented Oct 6, 2020

@marekro note that this is more tricky than this, as perldoc binary can be available but is a fake one until the perl-doc package is installed on the ubuntu containers.
So not only you need to ensure that perldoc is available but also that the default output looks sane...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent change makes test hang forever
2 participants