Limit sum of mix ratio to 1 unless disabled by M567 S0 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilriker
force-pushed
the
max-mixing-ratio
branch
2 times, most recently
from
4d222f1
to
646272d
Compare
|
One open question: when summing up the mix ratios in if (sum > 1.0) { return true; }? |
wilriker
changed the title
wilriker
force-pushed
the
max-mixing-ratio
branch
from
646272d
to
f45a1ae
Compare
|
Just pushed a minor change where the usual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in https://forum.duet3d.com/topic/6397/m567-mixing-ratio-limit-check this limits the maximum sum of mix ratio to 1. There is a switch to disable this per tool and this check is enabled by default.