Fix RetryFailedMessageMessage

DumitracheAdrian · May 4, 2024 · e248588 · e248588
1 parent fd2eb8a
commit e248588
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 26 deletions.
diff --git a/packages/messenger/Message/RetryFailedMessageMessage.php b/packages/messenger/Message/RetryFailedMessageMessage.php
@@ -4,31 +4,15 @@
 
 namespace Draw\Component\Messenger\Message;
 
-use App\Entity\MessengerMessage;
-use Draw\Component\Messenger\DoctrineEnvelopeEntityReference\Message\DoctrineReferenceAwareInterface;
-use Symfony\Component\Messenger\Exception\UnrecoverableMessageHandlingException;
-
-class RetryFailedMessageMessage implements DoctrineReferenceAwareInterface
+class RetryFailedMessageMessage
 {
-    private ?MessengerMessage $message;
-
     public function __construct(
-        MessengerMessage $message,
+        private string $messageId,
     ) {
-        $this->message = $message;
-    }
-
-    public function getMessage(): MessengerMessage
-    {
-        if (null === $this->message) {
-            throw new UnrecoverableMessageHandlingException('Message is not set.');
-        }
-
-        return $this->message;
     }
 
-    public function getPropertiesWithDoctrineObject(): array
+    public function getMessageId(): string
     {
-        return ['message'];
+        return $this->messageId;
     }
 }
diff --git a/packages/messenger/MessageHandler/RetryFailedMessageMessageHandler.php b/packages/messenger/MessageHandler/RetryFailedMessageMessageHandler.php
@@ -24,7 +24,7 @@ public function handleRetryFailedMessageMessage(RetryFailedMessageMessage $messa
                 [
                     $this->consolePath,
                     'messenger:failed:retry',
-                    $message->getMessage()->getId(),
+                    $message->getMessageId(),
                     '--force',
                 ]
             )

diff --git a/packages/messenger/Tests/MessageHandler/RetryFailedMessageMessageHandlerTest.php b/packages/messenger/Tests/MessageHandler/RetryFailedMessageMessageHandlerTest.php
@@ -4,7 +4,6 @@
 
 namespace Draw\Component\Messenger\Tests\MessageHandler;
 
-use App\Entity\MessengerMessage;
 use Draw\Component\Messenger\Message\RetryFailedMessageMessage;
 use Draw\Component\Messenger\MessageHandler\RetryFailedMessageMessageHandler;
 use Draw\Contracts\Process\ProcessFactoryInterface;
@@ -56,9 +55,7 @@ public function testHandleRetryFailedMessageMessage(): void
             ->method('mustRun');
 
         $this->handler->handleRetryFailedMessageMessage(
-            new RetryFailedMessageMessage(
-                (new MessengerMessage())->setId($messageId)
-            )
+            new RetryFailedMessageMessage($messageId)
         );
     }
 }
diff --git a/packages/sonata-integration-bundle/Messenger/Controller/MessageController.php b/packages/sonata-integration-bundle/Messenger/Controller/MessageController.php
@@ -25,7 +25,7 @@ public function retryAction(
         }
 
         $messageBus->dispatch(
-            new RetryFailedMessageMessage($message)
+            new RetryFailedMessageMessage($message->getId())
         );
 
         $this->addFlash(