-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new mytoyota api endpoints #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Awesome work man. So much effort during the last few weeks! Maybe you have a community shared coffee machine or beer tap as a German ;) ? |
Thank you, that's nice of you 😗 But if you have money to spare, spend it on someone who can really use it: |
You seem to be a really nice person, and I have done my duty with pleasure if that's what makes you happy :) |
The Regarding the sensors it seems we have to investigate further to find the correct conditions. |
Remote service should be enabled in the app, maybe there lays the problem? |
No, the problem is rather that I thought |
…is-drol/ha_toyota into enhancement/use_new_mytoyota_api
Should be fixed/adjusted now @DurgNomis-drol 😊 |
Can confirm it fixes it It's probably a replacement for the old starter battery sensor. Any clues why odometer and statistics does not work for me? |
The condition for statistics is currently that the vehicle is telemetry-capable. However, this might be something that we should investigate with the actual |
Signed-off-by: Pierre Belloy <[email protected]>
…is-drol/ha_toyota into enhancement/use_new_mytoyota_api
The statistics sensors should now be available @DurgNomis-drol. |
output from mytoyota |
So there are also no values for odometer etc. because your vehicle does not support telemetry (https://github.com/DurgNomis-drol/mytoyota/blob/master/mytoyota/models/vehicle.py#L64). Have you looked at what comes back from the endpoint if you bypass the conditions in the By the way, I think this is getting a bit off topic here. 😉 Shouldn't we move the search for your Odometer values to an issue in the mytoyota repo? |
Just loaded the latest commit and all is working as expected for me 💪 |
@CM000n Yes we should, will open an issue over there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Love your hard work on this!
This MR uses a
mytoyota
version >= 1.0 and therefore also the newctpa-oneapi
API version from Toyota for the Home Assistant toyota Custom Component.Some of the previous functionalities of the custom component have been removed as they are not (yet) supported by the revised
mytoyota
lib version.