Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "setup Connected Services Error" due to latest API Changes #240

Merged
merged 10 commits into from
Nov 12, 2023
Merged

Fix "setup Connected Services Error" due to latest API Changes #240

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
296f99a
Fix "setup Connected Services Error" due to latest API Changes
CM000n Nov 9, 2023
6984d79
Fix linting and adjust tests
CM000n Nov 9, 2023
9266f92
Merge branch 'DurgNomis-drol:master' into master
CM000n Nov 9, 2023
9adbaba
Fix github workflows and run poetry update
CM000n Nov 9, 2023
2a9fdd9
Fix github workflows and run poetry update
CM000n Nov 9, 2023
9754f7c
Fix github workflows and run poetry update
CM000n Nov 9, 2023
5a2ff9a
drop python 3.7 support and update pylint
CM000n Nov 10, 2023
077d555
Add checks to prevent TypeError when vin's are wrong
joro75 Nov 12, 2023
e551659
'Prettied' code to comply to code formatter
joro75 Nov 12, 2023
c4c8a1a
Removed deprecated 'no-self-use' pylint check
joro75 Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
fail-fast: false

steps:
Expand All @@ -34,7 +34,7 @@ jobs:
- name: Install Poetry
uses: abatilo/[email protected]
with:
poetry-version: 1.2.2
poetry-version: 1.5.1

- name: Install dependencies
run: poetry install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Pre-commit
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
runs-on: ubuntu-latest
env:
OS: ubuntu-latest
Expand All @@ -29,7 +29,7 @@ jobs:
- name: Install Poetry
uses: abatilo/[email protected]
with:
poetry-version: 1.2.2
poetry-version: 1.5.1

- name: Install dependencies
run: poetry install
Expand Down
12 changes: 10 additions & 2 deletions mytoyota/models/vehicle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,17 @@ def is_connected_services_enabled(self) -> bool:
if self.vin and self._connected_services:
if (
"connectedService" in self._connected_services
and "status" in self._connected_services["connectedService"]
and "devices" in self._connected_services["connectedService"]
):
if self._connected_services["connectedService"]["status"] == "ACTIVE":
vin_specific_connected_service = None
for device in self._connected_services["connectedService"]["devices"]:
if device.get("vin") == self.vin:
vin_specific_connected_service = device
break
if (
vin_specific_connected_service
and vin_specific_connected_service.get("state") == "ACTIVE"
):
return True

_LOGGER.error(
Expand Down
Loading
Loading