Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing attachments in non-multipart emails #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ischekoldin
Copy link

@ischekoldin ischekoldin commented Jan 14, 2021

There are emails with no text in the body that contain only a binary attachment. Mail clients handle those as proper attachments yet parsemail doesn't recognize them.

@Lngramos
Copy link

Lngramos commented Mar 14, 2021

Hello, @ischekoldin - thanks for this, it's exactly what I needed 🙌

@DusanKasan what can be done so this merged in? (thanks for the great library too, by the way)

Aside from the incorrect go.mod file - do we need some test coverage added around this use case? Happy to help towards getting this merged, as I'd much rather use your project as an upstream than using relying on a fork to use these changes.

@Lngramos
Copy link

p.s. have also just come across #25 which looks like that may also address this use case, indirectly.

@k3a k3a mentioned this pull request Aug 26, 2023
@k3a k3a mentioned this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants