Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Layout with Filament Grid Style and HasColumns Trait #16

Merged
merged 5 commits into from
Oct 12, 2024

Conversation

slimani-dev
Copy link
Contributor

Overview

This update addresses layout issues in the developer logins component by implementing Filament's grid system and the HasColumns trait. These changes ensure the layout displays correctly across different screen sizes and provides better flexibility.

Details

  • Grid Layout: Replaced the previous layout setup with Filament's grid system, which ensures consistent and correct display across screen sizes.
  • HasColumns Trait: Added the HasColumns trait for easier column management, allowing for customizable layouts and improved responsiveness.
  • Documentation Update: Enhanced the README with a detailed guide on using the columns() method to adjust the grid layout.

Why this change?

The previous layout was not displaying correctly, causing inconsistencies in the design. By switching to Filament's grid system and HasColumns trait, the layout now displays as intended across various devices and screen sizes.

Testing

These changes were verified locally, focusing on different screen sizes to ensure the layout displays as expected and remains consistent.

- Corrected layout issues by applying Filament's grid system for
  consistent display across screen sizes.
- Integrated HasColumns trait to manage column layout more effectively
  and improve responsiveness.
- Updated README with documentation on customizing the grid layout using
  the columns() method.
@dododedodonl dododedodonl requested a review from bramr94 October 8, 2024 01:14
fix: Clear session password hash on logout to prevent route error (DutchCodingCompany#15)
Copy link
Collaborator

@bramr94 bramr94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the merge conflicts?

README.md Outdated Show resolved Hide resolved
resources/views/components/developer-logins.blade.php Outdated Show resolved Hide resolved
src/FilamentDevelopersLogin.php Outdated Show resolved Hide resolved
@bramr94 bramr94 mentioned this pull request Oct 11, 2024
@slimani-dev
Copy link
Contributor Author

fixed all the problems with the merge conflict and the docs

@bramr94 bramr94 merged commit 7dab070 into DutchCodingCompany:main Oct 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants