Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#7284: Disable x86-64-alpine-3_21 in x86 workflow until fixed #7286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xdje42
Copy link
Contributor

@xdje42 xdje42 commented Feb 19, 2025

x86-64-alpine jobs are failing with "gzip: stdin: not in gzip format" https://github.com/DynamoRIO/dynamorio/actions/runs/13400978358/job/37431540308?pr=7282

Disable the job until it's fixed.

x86-64-alpine jobs are failing with "gzip: stdin: not in gzip format"
https://github.com/DynamoRIO/dynamorio/actions/runs/13400978358/job/37431540308?pr=7282

Disable the job until it's fixed.
@@ -245,6 +245,8 @@ jobs:
# 64-bit Linux build with gcc and musl.
# TODO i#1973: Fix failing cases and enable tests in CI.
x86-64-alpine-3_21:
# TODO i#7284: Disabled until fixed
if: false
runs-on: ubuntu-22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please try replacing the URL at line 269 with https://dl-cdn.alpinelinux.org/v3.21/main/x86_64/apk-tools-static-2.14.6-r3.apk?

I suspect that would fix this failure and we wouldn't need to disable it at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emphasis on "suspect". Maybe it will, but I'd rather follow protocol and put that responsibility on the owner.

I was given a choice, and now you're saying I don't have a choice. What changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling a CI test suite has its obvious downsides: more regressions can happen until it is brought back up. Since the URL fix was trivial, I thought it was reasonable to expect that we would try doing that first so we wouldn't have to live without test coverage for any amount of time.

In any case, #7289 fixes the original issue and more. So we can now drop this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants