Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5383: fix 'debug' field in mac drdeploy checks #7307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndrewh
Copy link
Contributor

@ndrewh ndrewh commented Feb 26, 2025

Issue: #5383

@ndrewh
Copy link
Contributor Author

ndrewh commented Feb 26, 2025

You cannot use drrun (without -nocheck) with release builds on macOS since lib64/debug/libdrpreload.dylib is not present in release builds, yet it does not have the debug flag set

relevant bit of code:

dynamorio/tools/drdeploy.c

Lines 576 to 587 in 898d3fb

if (!nocheck &&
((preinject && checked_files[i].is_preinject) ||
(!preinject && debug && checked_files[i].is_debug) ||
(!preinject && !debug && !checked_files[i].is_debug)) &&
checked_files[i].platform == dr_platform) {
/* We don't want to create a .1config file that won't be freed
* b/c the core is never injected
*/
if (report) {
error("cannot find required file %s\n"
"Use -root to specify a proper DynamoRIO root directory.",
buf);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant