Skip to content

Commit

Permalink
Remove unnecessary unit-test,
Browse files Browse the repository at this point in the history
  • Loading branch information
gkrenn committed Nov 22, 2024
1 parent 483764d commit 6b753f2
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions pkg/controllers/dynakube/activegate/reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -482,29 +482,6 @@ func TestServiceCreation(t *testing.T) {
assertContainsAllPorts(t, expectedPorts, activegateService.Spec.Ports)
}
})

t.Run("service exposes all ports for all capabilities", func(t *testing.T) {
fakeClient := fake.NewClient(testKubeSystemNamespace)

reconciler := NewReconciler(fakeClient, fakeClient, dk, dynatraceClient, nil, nil).(*Reconciler)
reconciler.connectionReconciler = createGenericReconcilerMock(t)
reconciler.versionReconciler = createVersionReconcilerMock(t)
reconciler.pullSecretReconciler = createGenericReconcilerMock(t)

dk.Spec.ActiveGate.Capabilities = []activegate.CapabilityDisplayName{
activegate.RoutingCapability.DisplayName,
}
expectedPorts := []string{
consts.HttpServicePortName,
consts.HttpsServicePortName,
}

err := reconciler.Reconcile(context.Background())
require.NoError(t, err)

activegateService := getTestActiveGateService(t, fakeClient)
assertContainsAllPorts(t, expectedPorts, activegateService.Spec.Ports)
})
}

func assertContainsAllPorts(t *testing.T, expectedPorts []string, servicePorts []corev1.ServicePort) {
Expand Down

0 comments on commit 6b753f2

Please sign in to comment.