Update unit tests

Dynatrace · Nov 22, 2024 · 8b6bcde · 8b6bcde
1 parent 659c133
commit 8b6bcde
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/pkg/controllers/dynakube/conditions.go b/pkg/controllers/dynakube/conditions.go
@@ -6,6 +6,11 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+const (
+	TokenReadyConditionMessage             = "Token ready"
+	TokenWithoutDataIngestConditionMessage = "Token ready, DataIngest token not provided"
+)
+
 func (controller *Controller) setConditionTokenError(dk *dynakube.DynaKube, err error) {
 	tokenErrorCondition := metav1.Condition{
 		Type:    dynakube.TokenConditionType,
@@ -18,9 +23,9 @@ func (controller *Controller) setConditionTokenError(dk *dynakube.DynaKube, err
 }
 
 func (controller *Controller) setConditionTokenReady(dk *dynakube.DynaKube, dataIngestTokenProvided bool) {
-	msg := "Token ready, DataIngest token not provided"
+	msg := TokenWithoutDataIngestConditionMessage
 	if dataIngestTokenProvided {
-		msg = "Token ready"
+		msg = TokenReadyConditionMessage
 	}
 
 	tokenErrorCondition := metav1.Condition{

diff --git a/pkg/controllers/dynakube/controller_test.go b/pkg/controllers/dynakube/controller_test.go
@@ -561,7 +561,27 @@ func TestTokenConditions(t *testing.T) {
 		_, err := controller.setupTokensAndClient(ctx, dk)
 
 		require.NoError(t, err)
-		assertCondition(t, dk, dynakube.TokenConditionType, metav1.ConditionTrue, dynakube.ReasonTokenReady, "")
+		assertCondition(t, dk, dynakube.TokenConditionType, metav1.ConditionTrue, dynakube.ReasonTokenReady, TokenWithoutDataIngestConditionMessage)
+
+		fakeClient = fake.NewClient(&corev1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      testName,
+				Namespace: testNamespace,
+			},
+			Data: map[string][]byte{
+				dtclient.ApiToken:        []byte(testAPIToken),
+				dtclient.DataIngestToken: []byte(testAPIToken),
+			},
+		})
+		controller = &Controller{
+			client:                 fakeClient,
+			apiReader:              fakeClient,
+			dynatraceClientBuilder: mockDtcBuilder,
+		}
+		_, err = controller.setupTokensAndClient(ctx, dk)
+
+		require.NoError(t, err)
+		assertCondition(t, dk, dynakube.TokenConditionType, metav1.ConditionTrue, dynakube.ReasonTokenReady, TokenReadyConditionMessage)
 	})
 }