Remove arch param where necessary #4065
Conversation
0sewa0
force-pushed
the
fix/no-arch-param
branch
from
70ce99a
to
264f5bc
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4065 +/- ##
==========================================
- Coverage 64.57% 64.46% -0.12%
==========================================
Files 400 400
Lines 26768 26724 -44
==========================================
- Hits 17286 17228 -58
- Misses 8126 8138 +12
- Partials 1356 1358 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0sewa0
force-pushed
the
fix/no-arch-param
branch
from
264f5bc
to
a84c533
Compare
0sewa0
requested review from
gkrenn,
chrismuellner,
albertogdd,
waodim,
StefanHauth,
aorcholski and
wepudt
| @@ -28,7 +28,7 @@ func (dtc *dynatraceClient) GetEntityIDForIP(ctx context.Context, ip string) (st | |||
| } | |||
|
|
|||
| // GetLatestAgent gets the latest agent package for the given OS and installer type. | |||
| func (dtc *dynatraceClient) GetLatestAgent(ctx context.Context, os, installerType, flavor, arch string, technologies []string, skipMetadata bool, writer io.Writer) error { | |||
| func (dtc *dynatraceClient) GetLatestAgent(ctx context.Context, os, installerType, flavor, arch string, technologies []string, skipMetadata bool, writer io.Writer) error { // TODO: does flavor/arch needed? | |||
There was a problem hiding this comment.
seems it is needed! For downloading the actual package it makes sense as well
| flavor = arch.Flavor | ||
| } | ||
| flavor := determineFlavor(installerType) | ||
| _arch := determineArch(installerType) |
There was a problem hiding this comment.
isn't _var usually for package/file wide vars?
Description
DAQ-2193
Adds logic that it tries to define the most correct affinity for the deployed components.
So from now on if the ActiveGate or the OneAgent images are from the tenant-registry then only the
amd64nodes are supported according to the affinity.versionis provided)In all other cases ("custom image") we use the broader affinity, based on the public-registry images (amd64, arm64, ppc64le, s390x)
How can this be tested?
public.ecr.aws/dynatrace/dynatrace-oneagent:1.303.55.20241122-143001,public.ecr.aws/dynatrace/dynatrace-activegate:1.303.25.20241118-125000