Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom version for cloudnative #4110

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Nov 26, 2024

Description

Currently the version field is ignored for CloudNativeFullStack deployments. This PR enables the custom version for CloudNativeFullStack.

Jira

How can this be tested?

  • Deploy CloudNativeFullStack with a custom OneAgent version set
    • OneAgent daemonset should have the custom version set + CodeModules should use the correct version (hence the CSI driver needs to download the correct version too)
  • Deploy CloudNativeFullStack with custom OneAgent version + custom CodeModules image set
    • the CodeModules image should be preferred

@gkrenn gkrenn requested a review from a team as a code owner November 26, 2024 14:02
@gkrenn gkrenn added the core Changes to core functionality of the Operator label Nov 26, 2024
@gkrenn gkrenn force-pushed the feature/customversion-cloudnative branch from 8f743e4 to 75aae4e Compare November 26, 2024 14:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.45%. Comparing base (6fa8b52) to head (c3708a8).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
- Coverage   64.46%   64.45%   -0.01%     
==========================================
  Files         399      399              
  Lines       26739    26735       -4     
==========================================
- Hits        17236    17232       -4     
  Misses       8150     8150              
  Partials     1353     1353              
Flag Coverage Δ
unittests 64.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismuellner
Copy link
Collaborator

Please make sure to cherrypick to 1.4 release branch as well!

@0sewa0 0sewa0 enabled auto-merge (squash) November 28, 2024 07:56
@0sewa0 0sewa0 merged commit c282f37 into main Nov 28, 2024
15 checks passed
@0sewa0 0sewa0 deleted the feature/customversion-cloudnative branch November 28, 2024 08:00
0sewa0 added a commit that referenced this pull request Nov 28, 2024
0sewa0 added a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants