Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn User if Redmodding Support Not Detected when REDdeploying #305

Open
effs opened this issue Nov 21, 2022 · 0 comments · May be fixed by #330
Open

Warn User if Redmodding Support Not Detected when REDdeploying #305

effs opened this issue Nov 21, 2022 · 0 comments · May be fixed by #330
Labels
defect Something isn't working at all or correctly Load Order Stuffs related to LO implementation REDmodding
Milestone

Comments

@effs
Copy link
Collaborator

effs commented Nov 21, 2022

We shouldn't be loading any Redmodding stuff until and if the DLC is installed. This is probably not the case atm.

I don't remember if there was an issue on this already but might be the feature desired vs feature enabled distinction (i.e. we may want to have Redmodding on but if the DLC isn't installed, then it's not enabled.)

It's difficult to actually only enable things when Redmodding is really enabled because it's a dynamic parameter.

It's possible for the user to install REDmods (or have autoconversion on) without the Redmodding DLC being installed. Rather than prevent or ignore it, let's show a warning.

Showing the warning right before a REDdeployment is a narrower change and probably clearer than the error message they would get, but on the other hand showing it on either install or enable of a REDmod might be a more timely one. Has to be less intrusive in that case though.

Maybe both best - a notification when installing, and a dialog when REDdeployment would occur?

@effs effs added defect Something isn't working at all or correctly REDmodding Load Order Stuffs related to LO implementation labels Nov 21, 2022
@effs effs added this to the 0.9.3 milestone Nov 21, 2022
@effs effs modified the milestones: 0.9.3, 0.9.4, 0.9.5 Dec 1, 2022
@effs effs changed the title Only Load Redmodding Stuff if Redmodding is Actually Enabled Warn User if Redmodding Support Not Detected when REDdeploying Dec 3, 2022
@effs effs modified the milestones: 0.9.5, 0.10.0 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working at all or correctly Load Order Stuffs related to LO implementation REDmodding
Projects
None yet
1 participant