📰 Warn User if Redmodding Tools not Available Either when Installing or when REDdeploying #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effs
force-pushed
the
feat/308/warn-when-reddeploy-with-no-redtools
branch
from
9f150e7 to
2124524
Compare
Split feature type stuff out for testability, re-export for now Removed unused vortex settings path record. The paths are different for the get/set cases so it's not useful. Removed unused `IfFeatureEnabled`, might be useful later.
Because that's what it is. And we'll have a separate non-user-controlled dynamic feature coming up next..
effs
force-pushed
the
feat/308/warn-when-reddeploy-with-no-redtools
branch
2 times, most recently
from
dde38ff to
9d985ce
Compare
E1337Kat
reviewed
Dec 10, 2022
Comment on lines
-41
to
-48
| export const detectREDmoddingDlc = (state: VortexState, gameId: string): VortexToolDiscovered => { | ||
| const tools = state.settings.gameMode.discovered[gameId]?.tools || {}; | ||
| return Object.keys(tools).map((id) => tools[id]) | ||
| .filter((iter) => (iter !== undefined) && (iter.path !== undefined)) | ||
| .find((iter) => path.basename(iter.path).toLowerCase() === `redMod.exe`); | ||
| }; | ||
|
|
||
|
|
There was a problem hiding this comment.
This is removed because it wasn't used?
effs
force-pushed
the
feat/308/warn-when-reddeploy-with-no-redtools
branch
from
802322e to
1d1010b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating another feature type to support this case.
Closes #305